Fix Python version detection in runtests.py (broken for Python 3.10) - Githubissues

aio-libs / aiozmq

Asyncio (pep 3156) integration with ZeroMQ

aiozmq.readthedocs.org

BSD 2-Clause "Simplified" License

422 stars 56 forks source link

Fix Python version detection in runtests.py (broken for Python 3.10) #171

Closed musicinmybrain closed 3 years ago

musicinmybrain commented 3 years ago

What do these changes do?

Compare versions as tuples instead of strings, so that Python 3.10 is detected as >= Python 3.3.

Are there changes in behavior for the user?

Tests work on Python 3.10 instead of complaining that Python 3.3 or higher is needed.

Related issue number

Checklist

[x] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
- .feature: Signifying a new feature.
- .bugfix: Signifying a bug fix.
- .doc: Signifying a documentation improvement.
- .removal: Signifying a deprecation or removal of public API.
- .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Is all that documentation really needed for such a trivial fix?