search

aio-libs / aiozmq

Asyncio (pep 3156) integration with ZeroMQ
aiozmq.readthedocs.org
BSD 2-Clause "Simplified" License
422 stars 56 forks source link

Python 3.10: wait_for() got an unexpected keyword argument 'loop' #175

Closed nirvana-msu closed 2 years ago

nirvana-msu commented 3 years ago

Python 3.10 removed the loop parameter from a number of asyncio coroutines, including e.g. wait_for. Most have been deprecated since 3.8. aiozmq still explicitly passes loop in some cases, breaking the code in 3.10.

I can see you've removed some of them in https://github.com/aio-libs/aiozmq/commit/a9d70f1f45f3493450a4f9d6fff0507894037651, but not all.

E.g. my code is failing at: https://github.com/aio-libs/aiozmq/blob/1cde8c6831d63e6a778390ce1ce422d6d27f2ab8/aiozmq/rpc/util.py#L25

JelleZijlstra commented 2 years ago

Fixed in the latest release, https://pypi.org/project/aiozmq/1.0.0/