aio-libs / propcache

Fast property caching
Apache License 2.0
7 stars 1 forks source link

Fix overload branch coverage exclude #40

Closed bdraco closed 2 weeks ago

bdraco commented 2 weeks ago

overloads are always unreachable at runtime

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.27%. Comparing base (416a3b2) to head (9ca0563). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/propcache/_helpers_py.py 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #40 +/- ## ======================================= Coverage 88.27% 88.27% ======================================= Files 17 17 Lines 691 691 Branches 67 67 ======================================= Hits 610 610 Misses 63 63 Partials 18 18 ``` | [Flag](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [CI-GHA](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `88.27% <0.00%> (ø)` | | | [MyPy](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `72.31% <0.00%> (ø)` | | | [OS-Linux](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `98.37% <ø> (ø)` | | | [OS-Windows](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `93.60% <ø> (ø)` | | | [OS-macOS](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.13% <ø> (ø)` | | | [Py-3.10.11](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `92.83% <ø> (ø)` | | | [Py-3.10.15](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.43% <ø> (ø)` | | | [Py-3.11.10](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.43% <ø> (ø)` | | | [Py-3.11.9](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `92.83% <ø> (ø)` | | | [Py-3.12.6](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.43% <ø> (ø)` | | | [Py-3.13.0-rc.3](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.43% <ø> (ø)` | | | [Py-3.8.10](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `93.13% <ø> (ø)` | | | [Py-3.8.18](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.75% <ø> (ø)` | | | [Py-3.9.13](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `92.81% <ø> (ø)` | | | [Py-3.9.20](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.42% <ø> (ø)` | | | [Py-pypy7.3.11](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.47% <ø> (ø)` | | | [Py-pypy7.3.16](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.09% <ø> (ø)` | | | [Py-pypy7.3.17](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.11% <ø> (ø)` | | | [VM-macos-latest](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.13% <ø> (ø)` | | | [VM-ubuntu-latest](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `98.37% <ø> (ø)` | | | [VM-windows-latest](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `93.60% <ø> (ø)` | | | [pytest](https://app.codecov.io/gh/aio-libs/propcache/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `98.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 2 weeks ago

Seems unfixable without changing coverage settings. Maybe best to just leave it