Closed bdraco closed 2 weeks ago
Seems ok downstream in yarl
Seems ok in aiohttp
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 88.24%. Comparing base (
cc02c1f
) to head (883fdb7
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/propcache/_helpers_py.py | 33.33% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For calling code, this change could only remove errors, not introduce them (i.e. if using --warn-any-expr).
Before MyPy flags All Flags
After MyPy flags All Flags
Super confusing that Coverage not affected when comparing cc02c1f...883fdb7
in the CI checks and ..
Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review. https://github.com/aio-libs/propcache/pull/50#issuecomment-2397931538
https://mypy.readthedocs.io/en/latest/dynamic_typing.html#any-vs-object
If you’re not sure whether you need to use object or Any, use object – only switch to using Any if you get a type checker complaint.
I'd say we didn't get any complaints so that seems to be the prescribed way to go.
Too tired and jet lagged to revalidate so I'll leave this for someone else to ✅ and merge or I'll take a look again when I've had some sleep.
I think this is good to merge as-is, but I wasn't 100% on all the discussions above so I'll leave it until they are resolved above.
I think it's okay to merge. This is probably best we can do right now.
_Originally posted by @Dreamsorcerer in https://github.com/aio-libs/propcache/pull/38#discussion_r1790880159_