search

aio-libs / propcache

Fast property caching
Apache License 2.0
7 stars 1 forks source link

Drop Python 3.8 support #57

Closed bdraco closed 1 week ago

bdraco commented 2 weeks ago

What do these changes do?

Drop Python 3.8 support

3.8 has reached EOL as of the 7th of October https://devguide.python.org/versions/

Are there changes in behavior for the user?

Drop Python 3.8 support

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (d6e71b6) to head (c6a2845). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/propcache/_helpers_py.py 60.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #57 +/- ## ========================================== - Coverage 88.24% 88.07% -0.17% ========================================== Files 17 17 Lines 689 671 -18 Branches 70 67 -3 ========================================== - Hits 608 591 -17 + Misses 63 62 -1 Partials 18 18 ``` | [Flag](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [CI-GHA](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `88.07% <89.47%> (-0.17%)` | :arrow_down: | | [MyPy](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `77.54% <66.66%> (-0.30%)` | :arrow_down: | | [OS-Linux](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `99.32% <100.00%> (+0.94%)` | :arrow_up: | | [OS-Windows](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.23% <85.71%> (+0.57%)` | :arrow_up: | | [OS-macOS](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.93% <86.66%> (+0.75%)` | :arrow_up: | | [Py-3.10.11](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.59% <86.66%> (+1.71%)` | :arrow_up: | | [Py-3.10.15](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `97.29% <100.00%> (+1.82%)` | :arrow_up: | | [Py-3.11.10](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `97.29% <100.00%> (+1.82%)` | :arrow_up: | | [Py-3.11.9](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.59% <86.66%> (+1.71%)` | :arrow_up: | | [Py-3.12.7](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `97.29% <100.00%> (+1.82%)` | :arrow_up: | | [Py-3.13.0](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `97.29% <100.00%> (+1.82%)` | :arrow_up: | | [Py-3.8.10](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `?` | | | [Py-3.8.18](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `?` | | | [Py-3.9.13](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.57% <86.66%> (+1.71%)` | :arrow_up: | | [Py-3.9.20](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `97.28% <100.00%> (+1.83%)` | :arrow_up: | | [Py-pypy7.3.11](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `?` | | | [Py-pypy7.3.16](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `96.52% <100.00%> (+1.39%)` | :arrow_up: | | [Py-pypy7.3.17](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `96.53% <100.00%> (+1.38%)` | :arrow_up: | | [VM-macos-latest](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.93% <86.66%> (+0.75%)` | :arrow_up: | | [VM-ubuntu-latest](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `99.32% <100.00%> (+0.94%)` | :arrow_up: | | [VM-windows-latest](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.23% <85.71%> (+0.57%)` | :arrow_up: | | [pytest](https://app.codecov.io/gh/aio-libs/propcache/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `99.32% <100.00%> (+0.94%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 1 week ago

pre-commit config needs to be updated. Also, should we go top-down and drop 3.8 from aiohttp first? Currently, its changelog only mentions the drop in master / v4. Should 3.11 be released first?

Probably a good idea. I was waiting for digest auth / middle ware to land in 3.11 before releasing but no reason we can't release 3.11 tomorrow and land it in 3.12

Dreamsorcerer commented 1 week ago

pre-commit config needs to be updated. Also, should we go top-down and drop 3.8 from aiohttp first? Currently, its changelog only mentions the drop in master / v4. Should 3.11 be released first?

Probably a good idea. I was waiting for digest auth / middle ware to land in 3.11 before releasing but no reason we can't release 3.11 tomorrow and land it in 3.12

I think we should wait a little longer before releasing 3.11. I see no reason to block this on the aiohttp release though. FYI, if you look at https://pypistats.org/packages/aiohttp Python 3.8 is still the second most popular version most days. So, it'd be nice to keep the 3.10 release going till atleast the end of the year.

webknjaz commented 1 week ago

Okay, let's not block, then.