aio-libs / sockjs

SockJS Server
Apache License 2.0
118 stars 40 forks source link

Web socket transport fix #383

Closed norlyakov closed 4 years ago

norlyakov commented 4 years ago

What do these changes do?

Set WebSocketTransport to ignore empty frames and added the ability to process multi messages from clients.

Are there changes in behavior for the user?

The server will not decode json messages in frames anymore. '["{\"foo\": 123}"]' => "{\"foo\": 123}"

Added ability to process multi messages in a single frame from the client: '["msg1", "msg2"]'

Related issue number

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #383 into master will increase coverage by 1.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   75.51%   76.55%   +1.03%     
==========================================
  Files          16       16              
  Lines         866      866              
  Branches      122      122              
==========================================
+ Hits          654      663       +9     
+ Misses        177      169       -8     
+ Partials       35       34       -1     
Impacted Files Coverage Δ
sockjs/transports/websocket.py 63.38% <100.00%> (+12.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13e77f2...462bdc7. Read the comment docs.