aiondemand / AIOD-rest-api

Services for the core of AIoD: Authentication and the metadata catalogue with REST API.
https://api.aiod.eu
MIT License
10 stars 7 forks source link

Update docker workflow #302

Closed PGijsbers closed 5 months ago

PGijsbers commented 5 months ago

This PR updates the docker workflow:

A build cache is used to avoid double work between build and push jobs, but it seems to persist between workflows so this hopefully also speeds up the workflow. Otherwise, I would expect a slight slowdown as splitting the workflow into separate jobs (which run on separate runners), means we have to import/export the image from build to test.

I had hoped to be able to push the built image from build directly without rerunning build. While it uses cache now, and thus shouldn't take too much extra time, this largely negates the benefit of splitting build and test. I would consider merging those jobs again as it should result in a speed up, though it 'feels' nice that the jobs are now separate.

[!warning] Before merging, I still want to verify that the develop and release triggers and flow are set up appropriately. I will do this on a fork. But I don't suspect any (major) changes.

PGijsbers commented 5 months ago

I am fairly confident the workflow works as intended, as evidence: