Closed PGijsbers closed 5 months ago
I am fairly confident the workflow works as intended, as evidence:
build
and test
:develop
tag (the workflow fails to authenticate because I did not configure credentials in my fork).:v*
and :latest
tag (the workflow fails to authenticate because I did not configure credentials in my fork). Note that this is problematic if we ever were do releases for versions which are not most recent (e.g., bugfix patch on an old release). I don't think this will really come up, and even if so we can trigger the action also from the Actions
tag to re-release the :latest
image.A workflow dispatch can be used to run the workflow with the provided tag (in this case :workflow-dispatch
).
I noticed in the process one time the docker tests failing due to the backup test. I am not sure exactly how that happened. In this case however I did find that it is actually really nice that we split build
and test
, since I can re-run just the test
job independently.
So I think this is good to merge (but please let me know if the open thread is resolved).
This PR updates the docker workflow:
aiod/metadata_catalogue
. This happens when:latest
and whatever the version tag is e.g.,v1.3.20240308
.develop
docker-description.md
A build cache is used to avoid double work between
build
andpush
jobs, but it seems to persist between workflows so this hopefully also speeds up the workflow. Otherwise, I would expect a slight slowdown as splitting the workflow into separate jobs (which run on separate runners), means we have to import/export the image frombuild
totest
.I had hoped to be able to push the built image from
build
directly without rerunning build. While it uses cache now, and thus shouldn't take too much extra time, this largely negates the benefit of splittingbuild
andtest
. I would consider merging those jobs again as it should result in a speed up, though it 'feels' nice that the jobs are now separate.