search

aiongg / khiin

Khí-ín Tâi-gí phah jī hoat 起引台語拍字法
MIT License
4 stars 3 forks source link

DB refactor to use new lookup tables #4

Closed aiongg closed 1 year ago

aiongg commented 1 year ago

With the new lookup tables, there is no need at all for the token cache, which has been removed entirely. That had some downstream consequences for other areas that were using pointers to the cache, and those have all been resolved.

As of right now, the tests are mostly passing, the remaining errors seem to be some sort of ordering issue in candidate sorting.

aiongg commented 1 year ago

As of right now, the tests are mostly passing, the remaining errors seem to be some sort of ordering issue in candidate sorting.

The errors were due to the previous test DB being somewhat handmade and me being unable to reproduce it exactly. It's mostly sorted now, except for 2 tests, but it will probably be better to update the tests if I can't fix the test DB to match exactly what it was.