aiongg / khiin

Khí-ín Tâi-gí phah jī hoat 起引台語拍字法
MIT License
4 stars 3 forks source link

Regression: automatic mode not showing possible candidates #8

Open aiongg opened 1 year ago

aiongg commented 1 year ago

This was working prior at 54ce721489bd817af9ea7d2d82e5aaf621f18bd2 prior to the big DB refactor. Right now a simple input of lisi in automatic mode, which should produce 汝是 as the top candidate, does not show either. It looks like it has something to do with the tones not being typed out. I did change some things in the search process / CandidateFinder to do with the TaiToken::input_size property, which might affect this.

It could also be that because the key_sequences are now generated ahead of time in Python (see aiong/khiin-data), we are tagging the input_size property incorrectly. Maybe it should be the size of the original input, before any tones were stripped. (e.g. "li" should have an input size of 3 when it represents "li2".) I'm not sure if this has anything to do with it or not, but it might.

Needs more research.