search

aionnetwork / AIP

Network & Protocol Improvement Proposals for Aion
https://aion.network
16 stars 13 forks source link

EIP-161 Legacy issue #12

Closed iamyulong closed 5 years ago

iamyulong commented 5 years ago

I'm writing this issue to bring up some discussion. If it turns out to be useful, I will convert it into a proposal.

Based on EIP-161

Account creation transactions and the CREATE operation SHALL, prior to the execution of the initialisation code, increment the nonce over and above its normal starting value by one.

However, in FastVM only the CREATE opcode case is covered; new accounts created by creation transactions will have an initial nonce of zero.

This should not affect normal solidity usage (contract with empty code is less common), but may end up with storage changes rollback for some edge cases. In the following example, the storage changes will be discarded because the newly created account is considered as empty.

{
  "name": "stack_push",
  "description": "can push items to stack",
  "transactions": [
    {
      "type": "CREATE",
      "receiver": "",
      "value": "0",
      "data": {
        "raw": "7f000000000000000000000000000000010000000000000000000000000000000255"
      },
      "nrg": "1000000"
    }
  ]
}

https://github.com/aionnetwork/aion/blob/843761824132b2dfe2a6e8dbc5b755167f571718/modAion/src/org/aion/zero/db/AionRepositoryCache.java#L64-L74

Open questions:

jennijuju commented 5 years ago

Hi @yulongaion, thank you for submitting. However, if you are seeking for open discussion, please post a new topic on our Aion Forum at: https://forum.aion.network/ and mark the category as AIP Discussion.