Issue created by aionick (on Tuesday Nov 20, 2018 at 18:25 GMT)
This is a first step towards completing #288
It turns out the AionTransaction class has an unused field that was reserved for different types of transactions, which is exactly what we need for the web3 api to create a transaction.
Currently we have been using a VM enum to signal this, but continuing in this way complicates how a user is to sign a transaction offline, for example.
I'm still not a huge fan of the unused field, since it's a byte, and having to remember which number means avm and which means fvm is pretty clumsy. But it's a start on our way towards a full solution for now..
aionbot
commented
5 years ago
Issue created by aionick (on Tuesday Nov 20, 2018 at 18:25 GMT)
This is a first step towards completing #288
It turns out the
AionTransactionclass has an unused field that was reserved for different types of transactions, which is exactly what we need for the web3 api to create a transaction.Currently we have been using a
VMenum to signal this, but continuing in this way complicates how a user is to sign a transaction offline, for example.I'm still not a huge fan of the unused field, since it's a
byte, and having to remember which number means avm and which means fvm is pretty clumsy. But it's a start on our way towards a full solution for now..