aionnetwork / AVM

Enabling Java code to run in a blockchain environment
https://theoan.com/
MIT License
49 stars 25 forks source link

[CLOSED] Kernel executor needs to track block energy limit #319

Closed aionbot closed 5 years ago

aionbot commented 5 years ago

Issue created by aionick (on Monday Nov 26, 2018 at 15:35 GMT)

Blocks, in addition to transactions, also have the concept of an energy limit. The amount of energy 'in' a block is the sum of the amount of energy consumed by each of its transactions, and this sum is bound by the block limit.

Currently nothing is in place to ensure that transactions put into a block do not exceed this limit, and checks for this limit were ignored to simplify things. Now that we have removed the energy scaling we were previously doing we should be able to do the block energy limit checks properly.

aionbot commented 5 years ago

Comment by jeff-aion (on Monday Nov 26, 2018 at 18:30 GMT)

Something to note with this is the concurrent executor: the limit may only be applicable when deciding what transactions to write-back.

aionbot commented 5 years ago

Comment by aionick (on Friday Nov 30, 2018 at 18:27 GMT)

Closed by kernel commit: 48fd73cc6e7c50d3c9611123f4f6cc0e4abbc5ac