search

aionnetwork / AVM

Enabling Java code to run in a blockchain environment
https://theoan.com/
MIT License
49 stars 25 forks source link

"shell" formatting #344

Closed ghost closed 5 years ago

ghost commented 5 years ago

(very nice document btw)

jeff-aion commented 5 years ago

Is this shell or sh? They both seem the same but I suppose they should be literally the same (if just to avoid the question).

ghost commented 5 years ago

Was tired of typing "shell", tried "sh" and it worked.

Seeing your (justified) response here, I looked it up:

https://github.com/github/linguist/blob/master/lib/linguist/languages.yml#L4546-L4553

It's an alias, so all good!

jeff-aion commented 5 years ago

I suspected that they were aliases, since they did the same thing, but you might as well make them the same, just so nobody needs to ask why they are different, later. Typically, I don't worry about "consistency for consistency sake" but this case is simple enough since they have identical meanings.

Beyond that, I will look into whether or not we need any kind of "contributor agreement" before accepting external changes.

jeff-aion commented 5 years ago

Asked around and this won't require any special agreement, due to our license. I am more interested in getting this in than worrying about this documentation detail so I will merge this.

Thanks!