There is a concern that the removing of TransactionContext in 1ec8d502fa3f45c6f3e7ba337fd7a05281b32265 will cause an incorrect SideEffects object to be returned as part of the TransactionResult if an internal transaction fails. It is likely that this will happen because all existing logs will be erased if an internal transaction fails (not just those pertaining to the failed transaction).
If this is the case, this should be fixed, probably by maintaining a stack of SideEffects that we coalesce into a single object upon returning from the AVM.
There is a concern that the removing of
TransactionContextin 1ec8d502fa3f45c6f3e7ba337fd7a05281b32265 will cause an incorrectSideEffectsobject to be returned as part of theTransactionResultif an internal transaction fails. It is likely that this will happen because all existing logs will be erased if an internal transaction fails (not just those pertaining to the failed transaction).If this is the case, this should be fixed, probably by maintaining a stack of
SideEffectsthat we coalesce into a single object upon returning from the AVM.