Update prepack to escape string when accessing jlink to build rt

qoire commented 4 years ago

This is required to build the slimmed down version of Java we use as part of AionWallet (usually this is found in the rt folder). The behavior of the wallet not launching is due to:

The RT folder not being built because bash does not escape the jlink path link (which contains spaces).
Subsequently, the removal (?) of rt from the packaging, but the rt folder is a mandatory part of the build.

This leads to AionWallet.exe (whose binary is based on a batch file) failing to launch due to not finding the java rt. You can find what the executable does here for next time: https://github.com/aionnetwork/Desktop-Wallet/blob/master/scripts/aion_ui.bat

ali-sharif commented 4 years ago

Can confirm that build works correctly on windows 10 (64-bit) and ubuntu 19.10 (64 bit).

@qoire if you've validated this on Mac, then please go ahead and close this.

ali-sharif commented 4 years ago

Closed PR by mistake

aionnetwork / Desktop-Wallet

Update prepack to escape string when accessing jlink to build rt #255