add DUP17-32 and SWAP17-32 instructions to expand local variable number

aionnetwork / aion_fastvm

Aion's FastVM implementation

MIT License

33 stars 15 forks source link

add DUP17-32 and SWAP17-32 instructions to expand local variable number #40

Closed aion-camus closed 5 years ago

aion-camus commented 5 years ago

relax the local variable limit, support up to 32 items in local stack.

aion-camus commented 5 years ago

New revision number is named AION_V1 to let kernel know the current version of fvm. It should be under discussion for release schedule. Local variable contract for test is uploaded.

iamyulong commented 5 years ago

LGTM

aionick commented 5 years ago

I'm good with this, though I would like to see the "proof" of the test contract you wrote (an actual JUnit test that compiles it and uses it).

aion-camus commented 5 years ago

It is tested under Rust Kernel. In Java kernel, I just use run_v1 in FastVM module to lauch the new fvm. Anyone who works on Java kernel interface could have a better solution.

aionick commented 5 years ago

Gotcha. I will be fixing up some old fvm tests and adding some new ones in the coming weeks for all of this avm integration, so I'll add some for this.