search

aionnetwork / node_test_harness

A test harness for functional integration testing the Aion kernel(s)
MIT License
0 stars 4 forks source link

Test Harness tests should all be passing #60

Closed aionick closed 5 years ago

aionick commented 5 years ago

Some development has gone on and the tests have evidently become outdated in certain cases. We need to get this back on track and ensure that any updates to the Test Harness source code are only pushed to master if ant && ant test is passing.

Just to clarify, I'm talking about the tests that cover the actual Test Harness source code itself, in the TestHarness/ directory, not the tests that make use of the Test Harness (the ones in Tests/)

aionick commented 5 years ago

The reason that most of these tests were failing came down largely to the fact that we were using a private key that is no longer on our default genesis file. The private key has been updated and I also had to set the default network to CUSTOM to get some things up and running (as well as enabling rpc on the mainnet config). All pretty well minor fixes.

Looks like this commit 139cb18b45616d3b5e491345709d34b0a725b67c moved the integration tests out into a separate directory but did not update the ant script accordingly and so ant test is only running the 4 basic unit tests we have instead of the integ tests. Going to fix this up now.

aionick commented 5 years ago

Also considering moving the logic to copy the config & genesis files over into the tests themselves. This would mean that people running from their IDE don't have to worry about anything, and this means we could move these default config files into a single location and have both modules make use of them quite easily.

aionick commented 5 years ago

Decided against burdening all tests with the responsibility of updating the config & genesis files. However, since each of the integ tests in the TestHarness module rely on the TestHelper to set things up, I've made the TestHelper overwrite these files. Since the Tests directory already does this via gradle I'll leave it be.