search

aiorazabala / qmethod

R package to analyse Q methodology data
GNU General Public License v2.0
34 stars 18 forks source link

retrieve, do not recompute rotmat from principal #245

Closed maxheld83 closed 9 years ago

maxheld83 commented 9 years ago

to make the code cleaner, and more reliable, this would be really nice.

Currently, to get the rotmat, as is required for #171, we have to run all of the rotation procedures that are otherwise handled inside principal::psych separately, reproducing principal as far as possible. That sucks, and it is a source for error.

We have to do this, because unfortunately, psych does not return those rotmat objects, even though all of the downstream rotation procedures create this.

204 would be a backstop to this, but I don't think that's possible.

Here's SE: http://stackoverflow.com/questions/32157031/how-can-i-retrieve-impute-the-underlying-rotation-matrix-rotmat-from-psych

maxheld83 commented 9 years ago

ah, great, William Revelle just told me:

I will add that feature in the next release. (coming in about 2 weeks).

Maybe we can wait for that feature before we merge this PR, then – should make the code a lot easier, especially the edits to qmethod(), which I know @aiorazabala isn't too wild about :).

This will also open up a lot of great opportunities for the future, in terms of target rotations etc.

maxheld83 commented 9 years ago

done, the update to psych is out, and we can now just retrieve the rot.mat without recomputing it within qmethod.R. That makes the code * a lot* cleaner, and also minimizes changes to the base function qmethod.R.