aiorazabala / qmethod

R package to analyse Q methodology data

GNU General Public License v2.0

34 stars 17 forks source link

Refined grep() lines matching factor data structure names #361

Closed Serendipity31 closed 4 years ago

Serendipity31 commented 5 years ago

On lines 16, 18, 27, and 29 of the qdc() code, the grep() code was refined to match the exact/full name of data structures associated with each factor. This is required to facilitate the extraction of more than 9 factors. Without this, the code cannot distinguish 'f1' from 'f10'.

Serendipity31 commented 5 years ago

Small change, but hopefully a useful one...

codecov-io commented 5 years ago

Codecov Report

Merging #361 into master will not change coverage. The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #361   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          28     28           
  Lines        1331   1331           
=====================================
  Misses       1331   1331

Impacted Files	Coverage Δ
R/qdc.R	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17d9aca...290057b. Read the comment docs.

JonasGeschke commented 4 years ago

Has this edit been merged to the package yet (and uploaded to CRAN)? The option to extraction of more than 9 factors would be great => #363

JonasGeschke commented 4 years ago

for quick use, I now applied the edits locally. it works great, thanks @Serendipity31 !

aiorazabala commented 4 years ago

Thanks very much @Serendipity31 and @JonasGeschke , and very sorry for the delay in merging (I don't check github regularly). For a prompt response, in the future please drop me an email at aiora.zabala ... gmail ...