search

aiortc / aioquic

QUIC and HTTP/3 implementation in Python
BSD 3-Clause "New" or "Revised" License
1.69k stars 237 forks source link

ec.generate_private_key() is supposed to be given a curve instance. #455

Closed rthalley closed 10 months ago

rthalley commented 10 months ago

In this one place we gave a class instead, which Cryptography < 42.0.0 tolerates and fixes, but it will be deprecated in 42.0.0.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3cdecdd) 99.95% compared to head (f948943) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #455 +/- ## =========================================== + Coverage 99.95% 100.00% +0.04% =========================================== Files 25 25 Lines 4881 4881 =========================================== + Hits 4879 4881 +2 + Misses 2 0 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlaine commented 10 months ago

Thanks, go for it :)