search

aiortc / aioquic

QUIC and HTTP/3 implementation in Python
BSD 3-Clause "New" or "Revised" License
1.66k stars 236 forks source link

During address validation, count the entire received datagram #531

Closed jlaine closed 3 months ago

jlaine commented 3 months ago

For anti-amplification purposes, servers need to keep track of the amount of data received on unvalidated network paths. We must count the entire datagram size regardless of whether packets are processed or dropped.

This is particularly important when talking to clients who pad datagrams containing INITIAL packets by appending bytes after the long-header packets, which is legitimate behaviour.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (79a8caf) to head (9c7d010).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 25 25 Lines 5098 5099 +1 ========================================= + Hits 5098 5099 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.