search

aiortc / aiortc

WebRTC and ORTC implementation for Python using asyncio
BSD 3-Clause "New" or "Revised" License
4.19k stars 759 forks source link

Fix reversed mid #1118

Open hilookas opened 3 months ago

hilookas commented 3 months ago

If no break statement in the changed file, the last unmatched transceiver will get. That will cause mid order different from addtrack() order in the multiple video track situation which is counterintuitive. This commit fixes it by breaking the loop in advance.

jlaine commented 3 months ago

Could you please write a unit test for this?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (22699ea) to head (670b967). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1118 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 30 30 Lines 5863 5864 +1 ========================================= + Hits 5863 5864 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.