Full stack project review

[outisa]

Hi @aiotrope!

I reviewed your Full stack project. You do not have to do anything to receive the credits, but if you like you can take advantage of my comments in this or future projects.

Application The application design is pleasant. As created a new user, in sign up if the password is too similar to the username, the error message shown in the app is "request failed with status code 404 - undefined". It seems that for some reason the error message is not shown even though it is in the response coming from the backend. The reason could be this. Should it be instead of this toast.error(`Error: ${error.message} - ${error.response.data.detail}`) like this toast.error(`Error: ${error.message} - ${error.response.data.message}`)?

I think I saw in some other component the latter one.

Code

• Code is well organized.
• Documentation is comprehensive.
• In general, instead of importing things like import * from 'library' it may be better to import exactly what is needed. This may cause problems, if libraries have functions with the same names. Although, I know that Yup documentation says exactly to do so.
• You have utilized formik well and in an advanced way.
• Also, nice to see that you have used linting.

Overall, well done!

[aiotrope]

Hi @outisa,

Thank you for reviewing my capstone project for this course; I will keep your suggestions in mind when I refactor the project codebase in the future.

More power to everyone involved in Full Stack Open; I learned a lot and had a great time.