search

aioutecism / amVim-for-VSCode

The Vim mode for Visual Studio Code(vscode) that works as expected.
https://marketplace.visualstudio.com/items/auiworks.amvim
456 stars 42 forks source link

Skip Up/Down keys if suggest widget is visible #319

Closed notiv-nt closed 1 year ago

notiv-nt commented 1 year ago

Problem: down/up keys don't work as expected if suggest is open

alisonatwork commented 1 year ago

Can I just confirm exactly the behavior you are expecting here, so we can document it on the changelog?

Currently, in insert mode, if the suggest widget appears, then using j and k just types the letters, whereas up and down navigate the suggestions.

In command mode the suggest widget won't ever appear unless you explicitly call it up with VSCode keypress Ctrl-Space. Then both j and k and the up/down arrows dismiss the widget and move the cursor up or down a row. This merge request should make it so that up and down arrows navigate the suggestions, like they do in insert mode.

One question I have is what should happen in visual mode and visual line mode? Is it okay to make the arrows navigate the suggestions and not move the selection? I feel like that should be okay because the suggestions will only appear if you explicitly asked for them in the first place, but just to confirm.

notiv-nt commented 1 year ago

For visual mode nothing changes i think (or at least i've changed already in my settings) And yes, if i explicitly call this widget, i expect to scroll through that with up/down keys

alisonatwork commented 1 year ago

Thanks for the explanation and for the fix! I will merge today and hopefully put out a new release this weekend.