search

aip-dev / google.aip.dev

API Improvement Proposals. https://aip.dev/
Other
1.08k stars 495 forks source link

Fix broken link #1429

Closed paladin-devops closed 1 week ago

paladin-devops commented 1 week ago

This commit fixes a link to AIP-202 in the documentation for AIP-129.

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

noahdietz commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Hi @paladin-devops you will need to resolve this for the change to be accepted :) If you'd rather not, lmk, and I can send a PR to fix this broken link as well and credit you

paladin-devops commented 1 week ago

@noahdietz thank you for reaching out! I would appreciate if you could PR this fix. 🙏🏻

I signed the CLA, but it seems that since I'm using my GitHub noreply email address (83741749+paladin-devops​@users.noreply.github.com) for commit signing, which here says that won't work with the CLA.

You may have Keep my email address private enabled. Without a visible email address, the CLA cannot be checked. Uncheck it and re-create the offending commit, or have your CLA point of contact add your @users.noreply.github.com address to the CLA group.

noahdietz commented 1 week ago

Done! Thanks I was able to manually verify your CLA signing and approve the contribution.

Then I promptly mixed up the number of the AIP being changed in the squashed commit - oops!

Thanks again!