aip-dev / google.aip.dev

API Improvement Proposals. https://aip.dev/
Other
1.1k stars 508 forks source link

AIP-160 grammar bugs #992

Open rofrankel opened 1 year ago

rofrankel commented 1 year ago

I think I've identified a couple bugs in the grammar provided by AIP-160:

This is probably not exhaustive - just what I've found after a few hours of playing with ANTLR4.

Given these bugs, I have to assume this grammar isn't actually what Google is using in prod. Would it be possible to update the grammar file to one that is a bit more battle-tested?

rofrankel commented 1 year ago

Well, the first two issues were resolved when I updated my TEXT terminal to include the - character. I suppose that's my mistake. But a related request is: could AIP-160 be updated to include a lexis?