Closed arbimo closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b56baea
) 85.12% compared to head (51950ae
) 85.13%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review! I'll merge it as it is then.
the problem reconstructed is not exactly the same since it doesn't contain the "general" defaults. But I don't think it is a problem. You can proceed with the merge.
You are right, but this will be reflected on the fluent's default (even though the problem will not be exactly similar if you were to add new fluents). I think I added this step of promoting a global default to a fluent default precisely because I was not very at ease with adding global default in the protobuf encoding ^^
Until now, all initial values (including implicit ones) written in the initial state when converting to protobuf. This is problematic as it means the problem reconstructed after export and importing to protobuf was not strictly equivalent: some implicit values were made explicit in process.
A bad consequence is that it made protobuf conversions much more expensive that it had too (even after the optimization of #559, 90% of the time spend remains in the initial state generation in at least some non trivial problems).
This PR only save to protobuf the explicitly set initial values. The defaults values of the fluent were already there.