Closed arbimo closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.29%. Comparing base (
ee56971
) to head (34e3070
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @arbimo , I've looked a bit into it and it seems the correct solution.
Indeed, lower in the code there is this check:
else: # expression longer than 3, must be a parameters list
for e in exp:
assert isinstance(e, List) or isinstance(
e, ParseResults
), f"expression {exp} is expected to be a parameters list, but it's not"
pass
so parameters can be either Lists
or ParseResults
.
Thanks for finding and fixing this!
@Framba-Luca Thanks for the feedback, I'll ask for it to be merged then ;)
This PR identifies a parser problem on an existing ANML domain.
The second commit adds a quick and dirty fix for it. However I have no knowledge of how it is actually supposed to work (and did not really dig into it). Hence it is likely the case that the problem is deeper that what is handled by the fix, which I really obtained by "randomly" changing things until it stops crashing...
@Framba-Luca could you have a look at it and see if it should be improved/generalized?