aiplan4eu / unified-planning

The AIPlan4EU Unified Planning Library
Apache License 2.0
181 stars 39 forks source link

deps: require numpy version 1.X.Y #617

Closed arbimo closed 2 months ago

arbimo commented 2 months ago

The recent release of numpy 2.0 seem to break some of our dependencies. If you were to re-run the CI on master before this commit, it would fail due to incompatible depenndencies.

This introduces a work around to ensure that we remain on a 1.X.Y version of numpy. I expect this to be removable once the ecosystem fixes their required dependencies.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.34%. Comparing base (d3ddd24) to head (027ee65).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #617 +/- ## ======================================= Coverage 85.34% 85.34% ======================================= Files 202 202 Lines 27272 27272 ======================================= Hits 23275 23275 Misses 3997 3997 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikand commented 2 months ago

Thanks for this Arthur. Did you discover whcih pair of deps caused this (so that we can monitor them)?

arbimo commented 2 months ago

No, but @nicola-gigante is I think the one who delved the most into this issue and may have more insights.

Note that we faced the same problem also for doc generation, where the dependencies are quite different.

nicola-gigante commented 2 months ago

@mikand if you have access to the old CI logs, you should see the name of the offending module in the Python stack trace, I think.