aiplan4eu / unified-planning

The AIPlan4EU Unified Planning Library
Apache License 2.0
194 stars 41 forks source link

Implement a unified_planning binding in scikit-decide #95

Closed mikand closed 1 year ago

mikand commented 2 years ago

@fteicht This is almost done, right? I think the only thing that is missing is to create a PyPI package for up-scikit-decide and to add it as a default solver in the UP.

Another thing FYK: in #156 we are creaing a simulator operation mode for the UP, this might greatly simplify yor code,

fteicht commented 2 years ago

@mikand I think the basic implementation is indeed almost done apart from the actions you mention. However, I noticed that the grounding of the problem is killing the approach on large problems: it takes hours before up-skdecide could even start solving the problem. To solve realistic instances, up should provide a lazy grounding mechanism where only the applicable actions are grounded on the fly for the current state (meaning that the feasible object instantiations of each action should be tested on the fly when evaluating each action's precondition formula). Or can you think of another solution to this grounding issue?

fteicht commented 2 years ago

To add a bit more on my previous comment: the approach I am describing proved to be effective for large Probabilistic PDDL benchmark. I implemented it and successfully tested it, see there and there for how the holds formula is actually evaluated for each possible formula class.