search

air-verse / air

☁️ Live reload for Go apps
GNU General Public License v3.0
16.53k stars 779 forks source link

feat: Make include_file overrule include_ext, fixes: #350, base_on: #358 #416

Open zhb127 opened 1 year ago

zhb127 commented 1 year ago

Fixes: #350

Base on: #358

I don't know, why marked #358 PR as draft?

Just fix code by #358 PR author's comments. then create new PR.

silverwind commented 1 year ago

Please add "Fixes: https://github.com/cosmtrek/air/issues/350" to your comment.

zhb127 commented 1 year ago

Please add "Fixes: #350" to your comment.

OK

silverwind commented 10 months ago

Bump, would love to see this merged.

nmfzone commented 10 months ago

Just to notify, I personally want to see this merged

park-jemin commented 8 months ago

Bump - would love to see this merged as well, seems it's been hanging for a while

silverwind commented 5 months ago

You should also include this change to actually test the changed functionality:

https://github.com/cosmtrek/air/pull/358/files#diff-c484509c25b7c8e4df331c9aefcbb49e43881a9a57c201a4491a4b7b61a72acb

zhb127 commented 5 months ago

You should also include this change to actually test the changed functionality:

https://github.com/cosmtrek/air/pull/358/files#diff-c484509c25b7c8e4df331c9aefcbb49e43881a9a57c201a4491a4b7b61a72acb

thx, The test code has been added.