air-verse / air

☁️ Live reload for Go apps
GNU General Public License v3.0
16.53k stars 779 forks source link

Why does it need a custom install.sh? #434

Closed coxley closed 9 months ago

coxley commented 1 year ago

This works just fine, and is common for Go commands:

go run github.com/cosmtrek/air@latest --help

# or

go install github.com/cosmtrek/air@latest

Recommending people curl | sh always feels sketchy. After taking a quick look, I didn't see anything in it that was necessary. I can only assume that go install works the same across each platform it supports. Maybe you've found that isn't the case, and can ignore me. :)

xiantang commented 9 months ago

when we use go install github.com/cosmtrek/air@latest, we can't put version by air -v

xiantang commented 9 months ago
    info, ok := debug.ReadBuildInfo()

I suppose that I can use logic like this : https://github.com/mvdan/gofumpt/blob/master/internal/version/version.go#L37

xiantang commented 9 months ago

image fixed