air-verse / air

☁️ Live reload for Go apps
GNU General Public License v3.0
16.53k stars 779 forks source link

`kill_delay` is in nanoseconds and not milliseconds as the example toml shows #436

Closed varunbpatil closed 9 months ago

varunbpatil commented 1 year ago

The example toml configuration file shows kill_delay as being in milliseconds

https://github.com/cosmtrek/air/blob/32675c4c222db3c187c2073340ccb3ff26ace1e2/air_example.toml#LL44C4-L44C4

but it is actually in nanoseconds which makes it unlike all the other time related configs which are in milliseconds.

varunbpatil commented 1 year ago

Unfortunately, fixing this, although easy, is a backward incompatible change. So, I'm fine with simply updating the example toml configuration file.

xiantang commented 10 months ago

I think modifying the toml configuration file will suffice. Can you submit a PR?