Pre & Post commands

[kareemmahlees]

closes #453

New Features

• A new option pre_cmd is added to .air.toml
• A new option post_cmd is added to .air.tom

New behavior

• commands that are in pre_cmd will be executed one by one before each build
• commands that are in post_cmd will be executed upon exiting (i.e. upon hitting ^C)

[kareemmahlees]

@xiantang could you review the changes made until now

[xiantang]

So, this time is it in support of the pre command?

[kareemmahlees]

So, this time is it in support of the pre command?

Yes, will work on the post command shortly.

[xiantang]

any update?

[kareemmahlees]

Sorry for the delay, I updated the tests hoping that they do a little more this time, unfortunately, I can't ensure that the tests are passing because there is a problem with t.tempDir on Windows specifically 😢

[xiantang]

The latest version of GO that I remember has already been fixed. You can try updating your GO version

[kareemmahlees]

I already have the latest version ( 1.21 ) installed, Sorry for being not so helpful but I can start working on post cmd if that's okay!

[xiantang]

Keep going

[kareemmahlees]

sorry for the delay, been busy at work. @xiantang could you check the latest changes?

[xiantang]

can let me check

On Wed, Sep 20, 2023 at 12:57 Kareem Ebrahim @.***> wrote:

sorry for the delay, been busy at work. @xiantang https://github.com/xiantang could you check the latest changes?

— Reply to this email directly, view it on GitHub https://github.com/cosmtrek/air/pull/461#issuecomment-1726970253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIHB3TYDMLYVHOZMZF4SLGLX3JZVDANCNFSM6AAAAAA4DOBUGI . You are receiving this because you were mentioned.Message ID: @.***>

[xiantang]

LGTM merged!

[xiantang]

thank you!

[jackielii]

Hmm, I thought post_cmd would run each time after cmd is restarted... it's surprising to call it post_cmd, should've been before_exit