air-verse / air

☁️ Live reload for Go apps
GNU General Public License v3.0
16.35k stars 771 forks source link

Adding Extra Logs for Config Reading Behaviour #517

Open matheusgomes28 opened 5 months ago

matheusgomes28 commented 5 months ago

Improves the logs for #516 . After looking into the codebase, I understand that the following behaviour is intended:

  1. read .air.toml if available.
  2. failing above, read .air.conf if available.
  3. failing above, use default configs.

The issue is that the user currently has no idea if they simply run air from their repo, with an invalid .air.toml. It is 100% clearer to log the behaviour so the user doesn't waste time (like I did) wondering why my .air.toml settings weren't picked up !

matheusgomes28 commented 5 months ago

Is air still under development? I can close PR if you guys aren't taking any more features

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (56d3d58) 69.22% compared to head (50daf32) 69.66%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #517 +/- ## ========================================== + Coverage 69.22% 69.66% +0.44% ========================================== Files 9 9 Lines 1082 1088 +6 ========================================== + Hits 749 758 +9 + Misses 253 251 -2 + Partials 80 79 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cosmtrek commented 5 months ago

@matheusgomes28 Thanks for your PR. Air is indeed still being maintained, though it is currently not in a phase of active development. We will periodically address issues and pull requests in batches.