search

air4children / site

:globe_with_meridians: Website of air4children
https://air4children.github.io/site/
MIT License
1 stars 0 forks source link

Feature/add site content #5

Closed amandujano closed 4 years ago

amandujano commented 4 years ago

new in this branch:

amandujano commented 4 years ago

Hi @amandujano Such great job you have made. I just added few comments that are mainly cosmetic ones and the update of some logo of air4children. Perhaps, it is important to put a README for permission of other images that we do not own. By the way is "package-lock.json" a temporal file? Maybe we do not needed it as well and we can add a gitignore for that one and others.

Hey @mxochicale . I added some fixes with your suggestions. You're right about the images, I am not using images by now, so I didnt use any reference for the permission.

I was also thinking about the type of Licence the project would have. Do you have some guidance in this topic?

amandujano commented 4 years ago

yep. I thinks is ready to be merged :)