search

airair / graphlabapi

Automatically exported from code.google.com/p/graphlabapi
0 stars 0 forks source link

engine_options().scheduler_type should return scheduler type, not raw option #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

IF I pass scheduler argument: --scheduler=round_robin\(max_iterations=3\),
then core.get_engine_options().scheduler_type will return 
"round_robin(max_iterations=3)",
while you would expect it to return just the scheduler type, "round_robin".

Would be better to do the parsing of the option in scheduler options, not 
engine factory
and separate to scheduler_type and scheduler_params.

Original issue reported on code.google.com by akyrola...@gmail.com on 12 Feb 2011 at 9:07

GoogleCodeExporter commented 9 years ago 
Hmm. We may need to rethink a little how the options system is managed... 
It is still a little chaotic and poorly documented.

Original comment by yucheng...@gmail.com on 13 Feb 2011 at 4:14

GoogleCodeExporter commented 9 years ago

Original comment by yucheng...@gmail.com on 7 Apr 2011 at 11:05