Extra account "deleted" from the subscription

airalab / robonomics.app

Manage your IoT devices through web3 infrastructure; Supports integration with Home Assistant

https://robonomics.app

BSD 3-Clause "New" or "Revised" License

14 stars 8 forks source link

Extra account "deleted" from the subscription #132

Open PaTara43 opened 6 months ago

PaTara43 commented 6 months ago

When about to delete an account from the subscription, two disappeared instead of one. Correct number after page refreshed. photo_3_2024-04-25_15-43-43 photo_2_2024-04-25_15-43-43 photo_1_2024-04-25_15-45-13

positivecrash commented 4 months ago

Needs to be rechecked after this current release came (is it still relevant)

nakata5321 commented 3 months ago

@PaTara43 re-check this please

PaTara43 commented 3 months ago

Okay, so now it indeed does not remove another account.

But when adding one, it disappears after transaction complete

all good after page refresh

vol4tim commented 3 months ago

Do you do this on the domain robonomics.app or dev.robonomics.app? This fix is currently only available on dev.robonomics.app

nakata5321 commented 3 months ago

This is now work in dev branch. Will be added in the next release.

Probably tested on c6efed0

nakata5321 commented 3 months ago

This is now work in dev branch. Will be added in the next release.

Tested again on commit 0e4836b and have same situation as in the beggining.

When delete account from "USERS IN SUBSCRIPTION", dissapeare one more account:

Begin: 4 accounts

Deleting account:

After delete: 2 accounts

And again reload page helps

nakata5321 commented 1 month ago

Update problem on comment https://github.com/airalab/robonomics.app/commit/24120c0c9a5d51c67d620cfe2bf4def7a6ea0248 tested on https://dev.robonomics.app/#/rws-setup.

When delete NOT the last account from subscription list, disappear two account. Example: I have this accounts list:

when I want to delete account in the middle of the list, we have got the next( i have 6 accounts): deleting account:

after finish see next. One more account disappear(only 4 accounts):

Still, after refreshing the page, again i see 5 accounts:

This problem appears only when user want to delete account in the middle of the list!

@vol4tim please check it

vol4tim commented 3 weeks ago

@positivecrash Problem with onUserDelete event in <robo-template-rws-setup component. Example: Load a page and pass a list of 3 addresses.

store.commit("rws/setUsers", [
  "4DK91",
  "4Hh22",
  "4Hd83"
]);

Then we remove the second address in the onUserDelete event, and the third address is also removed.

<robo-template-rws-setup :onUserDelete="removeUser" />

const removeUser = (user, setStatus) => {
  store.commit("rws/setUsers", [
    "4DK91",
    "4Hd83"
  ]);
  setStatus("ok");
}