search

airavata-courses / ABC

Apache License 2.0
0 stars 4 forks source link

Peer Review - Milestone 2 #99

Open arbansal opened 5 years ago

arbansal commented 5 years ago

The architecture diagram is well illustrated and wiki is descriptive and helpful. CI/CD through Jenkins is working just fine! The idea of the project is clear and test steps were easy to follow.

Some of the improvements (for next milestone) I can suggest are:

  1. A "Forgot password" and Profile image upload functionality.
  2. "Follow" button should change to "Following" post click
  3. Putting in a wrong password does not give any error (form validation is working fine for email though)
  4. Duplicate copies are being created at times (Creates 2 profiles in "Following" list when 1 profile was followed, 2 tweets on the dashboard when 1 post was made, etc.)

Overall, the project documentation, structure and implementation looks good!

absheth commented 5 years ago

Hi Arpit,

Thank you for your comments and I believe it is a constructive feedback.

We will try to incorporate a few of the improvements suggested above if not all :)