search

airavata-courses / CookieArmy

Apache License 2.0
0 stars 0 forks source link

Peer review milestone 1 #27

Closed alakhsingh closed 5 years ago

alakhsingh commented 5 years ago

First of all good job guys, I have a few suggestions

  1. In wiki, when you write request format, please do specify POST, GET or PUT methods to use for testing in postman.
  2. When you include instructions, you should also include instructions on how to fire up the service, in Linux/WIndows.
  3. Please specify, the path, how to run the service from command prompt, the commands etc.
  4. I highly recommend you writing all the sql commands in a .sql file which will make it easier.

Thanks, Alakh

jkumar10 commented 5 years ago

Thanks Alakh, we appreciate your time and effort in peer reviewing our project. We have addressed most of the issues that you faced and will continue to improve this application in further project cycles.