airavata-courses / DCoders

Spring 2022 Project
Apache License 2.0
1 stars 0 forks source link

Project 1 Review (Scapsulators) #18

Closed shubhpatr closed 2 years ago

shubhpatr commented 2 years ago

Just ran your project, It was not clear how to run the project, had to figure out the branch myself.

I'm running the project from feature/3-user-management-service.

On build getting this error : -

Error: Unable to access jarfile target/UserManagement-0.0.1-SNAPSHOT.jar

Do I need to have some prerequisite setup? Let me know if I am doing something wrong.

Reviewed by Team Scapsulators (https://github.com/airavata-courses/scapsulators)

vinayakasg18 commented 2 years ago

Hello Shubham, Thank you for the review. We haven't merged all the branches to main yet. Have you tried remote docker images?.

Let me know if you are able to run.

pranavacharya commented 2 years ago

Hello, I tried to run your project now. I also found it difficult to follow through the WIKI document https://github.com/airavata-courses/DCoders/wiki/local-runbook as mentioned by @shubhpatr

Can you provide steps to run remote docker images ?

Thanks. Team Garuda

vinayakasg18 commented 2 years ago

The commands are given on the same page. You need to have the docker installed on your machine (That's the prereq). https://github.com/airavata-courses/DCoders/wiki/local-runbook#follow-the-below-steps-to-run-the-application-locally

pranavacharya commented 2 years ago

Got it, thanks.

Maybe a note about which branch to checkout before each module might be helpful on https://github.com/airavata-courses/DCoders/wiki/local-runbook

Had to refer other parts of WIKI to figure it out.

Thanks, Team Garuda

vinayakasg18 commented 2 years ago

Got it. Thanks for the review. Will make the changes. 👍

vinayakasg18 commented 2 years ago

Just ran your project, It was not clear how to run the project, had to figure out the branch myself.

I'm running the project from feature/3-user-management-service.

On build getting this error : -

Error: Unable to access jarfile target/UserManagement-0.0.1-SNAPSHOT.jar

Do I need to have some prerequisite setup? Let me know if I am doing something wrong.

Reviewed by Team Scapsulators (https://github.com/airavata-courses/scapsulators)

Fixed the docker-compose issue. Could you please check if it is working for you now?.

vinayakasg18 commented 2 years ago

Resolved the docker-compose, and Mapbook M1 chip docker issue.