search

airavata-courses / Spark

Apache License 2.0
0 stars 0 forks source link

Peer review Assignment 4 #99

Open iarora93 opened 5 years ago

iarora93 commented 5 years ago

Can you please share the credentials for Jenkins.

iarora93 commented 5 years ago

Looks like there is some issue with the authentication service. Not able to login via OAuth or via normal id and password.

*Suggestion** 1)In your jenkinsfile, you are displaying login id and password your docker. This could be avoided by adding credentials in Jenkins Server itself.

2)The architecture looks good but you could have used separate Jenkins for TACC Server as it provides better availability and deployments can continue in a case even if one data center is down

kulsv commented 5 years ago

Hi, We have shared the Jenkins credentials via email. Also, authentication issue is now resolved.

About the suggestions,

  1. This is a valid point and we will surely implement this.
  2. Yes, a separate TACC Jenkins server is the right way to do it. But we were already facing a lot of issues with TACC VMs that having a Jenkins server on TACC wouldn't have been reliable. Also, since it was not one of the main goals for the milestone, we decided to go with IU Jenkins server for the better stability and reliability.

Thanks, Shweta

iarora93 commented 5 years ago

Hi Team, Everything seems to be working, Great job on the UI. Also smart move by using Kubernetes service names instead of IP addresses Nice work!