search

airavata-courses / SquirtleSquad

A squad as cool as the real Squirtle Squad!. Somehow obsessed with designing a weather prediction app to save the world from global warming!!
1 stars 2 forks source link

Peer Review For Milestone#2 #38

Open ViralPrajapati opened 4 years ago

ViralPrajapati commented 4 years ago

Please provide detail steps to check your CI/CD for this milestone. Also, please add my key so that I can ssh into your instances and check your fault tolerance, my key is ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDww/fMZYd9eFHlS4sOyW2wWNc5Kanoje3FCuHJgTqQKZTgqPXW/PLwyrZ+3QW10QyScAEn2baKQ/N6+h7Tffwlfzsq0+HmQ+lhqtfluc3bAEeDj5nHhQaS1fN7MO7Csm2SoXIpLR9DNy+W1aDBXRpFuzs6O7oCQchMKfWB9TZnkQrBWvG+TtkbuXJPPc5NUFYNnrZai9Difg++HR2K1GSsFE4WUgu+p8UP5DnrHl2YfqDWyEbHoJn0gz/EMcqxeHtv6wAGKz5SlIIjxQdYnv4tlRjAot5VULA4UTOuAcMFspl5gQjgeSg0b5t+ietp1FbOze4bB2ZWgwT7xyYuiaP7 Generated-by-Nova

ViralPrajapati commented 4 years ago
  1. Since your project is not yet deployed on jetstream there is no way I can check the fault tolerance of your system or check if CI/CD is working.
  2. If you can provide your docker hub repo name then maybe I can somehow check if you CI is working by making some changes to your code and checking if new image is being generated on the docker hub.
CleverParty commented 4 years ago

Please try to clone the "dockerized_services" branch and make any small changes to see the reflection on https://travis-ci.org/

ViralPrajapati commented 4 years ago

Ok, I have checked your CI by editing modelexecution file and it is running perfectly. Do let me know when you are done with deployment on jetstream so I can also check your CD and fault tolerance. Commit hash : https://github.com/airavata-courses/SquirtleSquad/commit/2ebf6dde0a6283319133f666b8161395b382cd82