Project Review

[amolsangar]

Everything looks good although I found one quick improvement area.

The weather API service is addressing requests one after another rather than handling them simultaneously. The requests are getting blocked until all of them are processed.

Using Async doesn't always give the desired results.

Test - sending 2 simultaneous requests getting processed one after another

Proposed solution - The default multithreading of Fast API can be used to tackle this problem. Replace the async function by normal (def) function which enables multithreading to handle requests otherwise disabled for async functions.

Replace this - @app.get("/weatherApi/plot") async def read_root(radar_id, date):

by this - @app.get("/weatherApi/plot") def read_root(radar_id, date):

Requests getting simultaneously processed.

Reference - https://medium.com/@rishibajargan/do-not-over-use-async-with-fastapi-fa70bed14d9c

Hope this helps!

- Team Puzzles

[sanket1211996]

@amolsangar Really Appreciate the feedback! Detailed explanation help us to understand the root cause. I was doubtful regarding the default multithreading and async call. You point it correctly even if async in place its not blocking the requests but just processing it one after another. We will take care of this in upcoming release work. Point Noted.

[SreeshaKS]

Good work on the peer review!