search

airavata-courses / alpha

Team Alpha Project Repo
0 stars 2 forks source link

PeerReview for MileStone2 #33

Closed harithadamarla closed 5 years ago

harithadamarla commented 5 years ago

Hi TeamAlpha,

Able to successfully build the application Jenkins. And accessed the application from the given url. Architechture diagram was great. Self Explanatory. UI was little clumsy. Could have been little better. Testing Further

Thanks, Haritha.D

harithadamarla commented 5 years ago

Tested by creating a new file in CI/CD branch. Automatic poll- triggered. Build success.

harithadamarla commented 5 years ago

Could see the Dockerfile for every branch. There is no docker-compose.yml or any script to pull the docker images. Have you containerized the microservices?

harithadamarla commented 5 years ago

I have tried signing up with 2 of my email id's and made sure that NewAlert is ON. I haven't received an email regarding any news update.

Not sure if I am missing anything. Would be easy if steps are properly documented

siddharthpathak commented 5 years ago

We were trying docker but we were not able to do it completely(All but java artifacts - Weather and DB microservice - were dockerized successfully). We are still working on dockerizing it. We have manually paused the notification service, because we didn't want to spam peer reviewers with mails the every hour. Will trigger it once, so that you can review the mail.

harithadamarla commented 5 years ago

Sure. Thanks.