Peer Review for project 2

airavata-courses / alpha

Team Alpha Project Repo

0 stars 2 forks source link

Peer Review for project 2 #34

Closed karanrk closed 5 years ago

karanrk commented 5 years ago

Good job with architecture diagram, clearly explains the use cases for Kafka and its implementation
Tried live demo with url given on the wiki page, all works fine - curious to know, how frequently are you guys updating the topic, because the stock updates too frequently (every second or so)
Also please let us know, if you guys have implemented service discovery, i know for a fact you were trying docker swarm.
For the CI/CD - can i build now and test the pipeline?

siddharthpathak commented 5 years ago

We are updating the web page using REST calls for News, and Weather every 30 mins. We plan to give user an option to select the update interval on UI in future. Stocks are updated every epoch using web socket communication. Because of the volatile and urgent nature of stock prices, we used web sockets. We are working on the service discovery part. Looking into both Docker swarm and zookeeper. We were able to dockerize all our artifacts, but Java artifacts (Weather and DB microservice). Yes, you can push a commit on the CI/CD branch or manually trigger the build.

karanrk commented 5 years ago

Manually triggered the build and tested out the pipeline, works fine.

I had a question - suppose If you were to push/edit a single line of code to any one microservice, with your current configuration it would build all the microservices and re-deploy all the microservices again which might impact the downtime for the whole application. You could build each microservice separately and deploy them separately. In this way you could keep the application live and only redeploy individual microservice.

aishwaryadhage commented 5 years ago

We were earlier building it in a single jenkinsfile. Thanks for the suggestion, we updated jenkinsfile to build and deploy each microservice separately.