search

airavata-courses / alpha

Team Alpha Project Repo
0 stars 2 forks source link

Peer Review Project 4 #63

Closed harithadamarla closed 5 years ago

harithadamarla commented 5 years ago

Hi Team,

The application has a great improvement in UI. I have checked your Jenkins configuration for ms-stocks branch. I could see that deployments are getting deleted followed by sleep for 20ms. Are you not experiencing a downtime after every code push ? Also, the credentials are not hidden which may not be a good practice.

harithadamarla commented 5 years ago

Even after clicking logout I believe session is not getting killed. I am directly able to access http://149.165.157.60:30005/App without logging in.

harithadamarla commented 5 years ago

Great job on System architecture and kubernetes dashboard, clearly depicting the system functionality and flow.

aishwaryadhage commented 5 years ago

Hello Haritha, Thanks for pointing out about the logout issue and credentials. The issue has been fixed, can you please check and let me know if there are any further issues.

harithadamarla commented 5 years ago

Hello Haritha, Thanks for pointing out about the logout issue and credentials. The issue has been fixed, can you please check and let me know if there are any further issues.

Hi Aishwarya,

Thanks. Could see that issue is fixed.

hardikrakholiya commented 5 years ago

Closing this issue now.