search

airavata-courses / alpha

Team Alpha Project Repo
0 stars 2 forks source link

Peer Review Project 4 #64

Open hardikrakholiya opened 5 years ago

hardikrakholiya commented 5 years ago

@karanrk Documentation is available on Project Milestone 4 in Wiki. Let me know if you need any help.

karanrk commented 5 years ago

Could you please send me the credentials for jenkins ?

aishwaryadhage commented 5 years ago

Hello, you can use "root" as pass and username

karanrk commented 5 years ago

Hi Team,

Good job with wiki documentation clearly highlighting the power of kubernetes and how it easily tackles the problem of client binding that was earlier done using zookeeper and in built load-balancing.

I have tried building your application on jenkins and good news - no failures. The best part is the fact that you guys have really improved working on CI/CD as i remember,you having built all the micro-services in a single pipeline. You have come really long way with respect to CI/CD.

Coming to Kubernetes part, great work as the whole application is up and running with Kubernetes cluster. It's nice to see the comparison of number of requests that Kubernetes could handle(83) versus load balancer implemented with zookeeper(16), i am more interested in the justification of this observation. I wonder, what is it that makes Kubernetes a clear winner.

Few minor things that could be improved,

On the whole, i enjoyed working (yes, i consider reviewing also as working) with you guys.

All the very best and Best Regards, Karan

hardikrakholiya commented 5 years ago

I will close this issue now.

aishwaryadhage commented 5 years ago

Hi Team,

Good job with wiki documentation clearly highlighting the power of kubernetes and how it easily tackles the problem of client binding that was earlier done using zookeeper and in built load-balancing.

I have tried building your application on jenkins and good news - no failures. The best part is the fact that you guys have really improved working on CI/CD as i remember,you having built all the micro-services in a single pipeline. You have come really long way with respect to CI/CD.

Coming to Kubernetes part, great work as the whole application is up and running with Kubernetes cluster. It's nice to see the comparison of number of requests that Kubernetes could handle(83) versus load balancer implemented with zookeeper(16), i am more interested in the justification of this observation. I wonder, what is it that makes Kubernetes a clear winner.

Few minor things that could be improved,

  • better error handling with respect to unregistered users trying to login to your application.
  • After 20-25 seconds of logging into your system, i don't see the stock and news microservice come up on the UI (stock says loading).

On the whole, i enjoyed working (yes, i consider reviewing also as working) with you guys.

All the very best and Best Regards, Karan

Hello Karan,

Thanks for sharing your thoughts about the system with us. About some minor changes that you mentioned, we are able to handle users error handling issue. Also, we checked if our system takes time to update UI but it instantly updates system for all the microservices after logging in.