Project 1 Feedback [Zilean]

airavata-courses / scapsulators

Looking to understand how weather phenomena in a region, affect your research? Well look no further!

https://github.com/airavata-courses/scapsulators/wiki/Weather-enthusiasts-assemble

Apache License 2.0

1 stars 2 forks source link

Project 1 Feedback [Zilean] #67

Open impiyush83 opened 2 years ago

impiyush83 commented 2 years ago

Likes:

Development looks crisp and as per industry standards.
SDLC processes and contributing guidelines are great!

Observations:

Each microservice needs to make an API call to database-connect microservice to make DB operations. Here, it increases one network hop which might hamper performance.

Piyush Nalawade

Team Zilean 🦄

RutujaJadhav19 commented 2 years ago

Hi Piyush,

Thanks for taking the time to review our project. Appreciate your feedback. The reason to implement every microservice connect to database-connect microservice to make DB operations is to follow the project guidelines given in Project 1 which states "Only one microservice can connect to each DBMS". We are using only one DBMS(Mongo DB) for our application and hence only database-connect microservice will connect to our database to perform any DB operations.

Team Scapsulators