search

airavata-courses / spring17-laravel-portal

Web Portal to experiment with Load Balancing
Apache License 2.0
4 stars 2 forks source link

Username password should not be checked into git #9

Open Ameya05 opened 7 years ago

Ameya05 commented 7 years ago

Docker username password should be tokenized via Travis-CI or Encrypted perhaps instead of being present in the code commits on git

https://github.com/airavata-courses/spring17-laravel-portal/blob/develop/scripts/install.sh

Ameya05 commented 7 years ago

Didnt work using tokens configured in Travis-CI

Might have to

  1. Encrypt password or
  2. Use token Replacement scripts
tilaks26 commented 7 years ago

I did try to create a .env file to store passwords. But it didn't seem to work as I expected. Can we remove read permissions to the script? We are anyway using it only to deploy the files, right?